Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `override list` not look horrible #214

Closed
brson opened this Issue Mar 30, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@brson
Copy link
Contributor

brson commented Mar 30, 2016

No description provided.

@peschkaj

This comment has been minimized.

Copy link
Contributor

peschkaj commented Mar 31, 2016

Took at stab at this over at peschkaj@eb4c973

To speed up review, current output looks like this on Windows:

TOOLCHAIN               TARGET
--------------------    ----------------------------------------
nightly-x86_64-msvc     \\?\D:\src\peschkaj\coreutils
nightly-x86_64-msvc     \\?\D:\src\peschkaj\flaker
nightly-x86_64-msvc     \\?\D:\src\peschkaj\multirust-rs
nightly-x86_64-msvc     \\?\D:\src\peschkaj\todo
stable-msvc             \\?\D:\src\test-rustup

The \\?\ isn't the prettiest thing on earth, but I wanted to get a 👍 or 👎 on the general output before attempting to format the string.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Mar 31, 2016

Thanks for taking this @peschkaj.

It looks great. I think though that I expect the paths to be in the first column, the toolchain in the second. Is that easy to do?

Also can you rename TARGET to PATH since 'target' already means 'target triple'?

My only reservation here is about the column headers. None of the other list commands have that (they also only have one column).

If you tackle fixing the display paths on windows you might grep the source for the two occurrances of of the word UNC where I've noted this same problem and fix them all.

@peschkaj

This comment has been minimized.

Copy link
Contributor

peschkaj commented Mar 31, 2016

I think though that I expect the paths to be in the first column, the toolchain in the second. Is that easy to do?

Very easy and I'll get on it.

Also can you rename TARGET to PATH since 'target' already means 'target triple'?
My only reservation here is about the column headers. None of the other list commands have that (they also only have one column).

Changing TARGET to PATH is easy enough to do. But in light of your second statement, I'll remove the header altogether. If we opt to add a header later, it's an easy enough change to make down the road.

I'll create a separate issue to clean up UNC paths just so there's a clean history.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Apr 6, 2016

Fixed. Thanks @peschkaj!

@brson brson closed this Apr 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.