Skip to content

/rustup.rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No info printed on `rustup target remove` #306

Closed
alexcrichton opened this Issue Apr 13, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
E-easy enhancement help wanted
Projects
None yet
Milestone
No milestone
3 participants
@alexcrichton @brson @Diggsey
@alexcrichton
Copy link
Member

alexcrichton commented Apr 13, 2016

Right now a successful rustup target remove doesn't actually print anything, whereas most other commands print out something like "successfully did blah".

@Diggsey Diggsey added this to Documentation & CLI in Issue Categorisation May 4, 2017

@Diggsey Diggsey added E-easy help wanted enhancement labels May 4, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented May 12, 2017

Since install says:

brian@ip-10-145-43-250:/mnt2/dev⟫ rustup target add i686-unknown-linux-gnu
info: downloading component 'rust-std' for 'i686-unknown-linux-gnu'
info: installing component 'rust-std' for 'i686-unknown-linux-gnu'

Seems like an appropriate message is

info: removing component 'rust-std' for 'i686-unknown-linux-gnu'

Neither indicates that the command was finally installed or removed, but saying "removing" is at least consistent with the existing logs, and it prints something.

@matthewjasper matthewjasper referenced this issue May 14, 2017

Merged

Add a message when removing a component #1119

bors added a commit that referenced this issue May 18, 2017

@bors
Auto merge of #1119 - matthewjasper:removing-message, r=Diggsey 
Add a message when removing a component

Fixes #306.
The message is (for example)
```
info: removing component 'rust-std' for 'x86_64-unknown-linux-musl'
```
Loading status checks…
53a3ee1

@bors bors closed this in #1119 May 18, 2017

@Diggsey Diggsey removed this from Documentation & CLI in Issue Categorisation May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.