Skip to content

/rustup.rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"update not yet available" message should not error #990

Closed
brson opened this Issue Mar 16, 2017 · 4 comments

Comments

Assignees
No one assigned
Labels
E-easy bug help wanted
Projects
None yet
Milestone
No milestone
2 participants
@brson @alisha17
@brson
Copy link
Contributor

brson commented Mar 16, 2017 

brian@DESKTOP-CODN6ST MINGW64 /c/Users/brian/Documents/dev/taskcluster-crater/rs
$ rustup update stable
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: update not yet available, sorry! try again later
error: checksum failed, expected: '6a73d4aa8eccdfe03fdd7ddd84685c8ccba3ca6516db0475197ef40a21686a52', calculated: '4cf9a1a74dd0d5fdf0b0fabf473e8940f759093b3a1f11c8cef7a9f554d99c5b'

The whole point of the "update not yet available" is to mask the spurious error!

@brson brson added the bug label Mar 16, 2017

@brson brson referenced this issue Mar 16, 2017

Closed

Checksum error on beta-x86_64-pc-windows-msvc #979

@brson brson added the help wanted label Mar 17, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Mar 17, 2017

The thing to do here is locate this code path and make it exit successfully instead of error.

@brson brson added the E-easy label Mar 17, 2017

@alisha17

This comment has been minimized.

Sign in to view
Copy link

alisha17 commented Mar 18, 2017

Can I take up this issue ?
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Mar 20, 2017

@alisha17 Yes you may!

@Diggsey Diggsey added this to Error messages & documentation in Issue Categorisation May 3, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented May 11, 2017

This work item is still available.

@crazymerlyn crazymerlyn referenced this issue May 15, 2017

Merged

Exit successfully on "update not yet available" #1120

bors added a commit that referenced this issue May 18, 2017

@bors
Auto merge of #1120 - crazymerlyn:checksum_fail_is_ok, r=Diggsey 
Exit successfully on "update not yet available"

Fixes #990.
Loading status checks…
1434889

@bors bors closed this in #1120 May 19, 2017

@Diggsey Diggsey removed this from Error messages in Issue Categorisation May 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.