Skip to content

/rustup.rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with panic=abort #992

Open
brson opened this Issue Mar 16, 2017 · 3 comments

Comments

Assignees
No one assigned
Labels
enhancement help wanted
Projects
Build in Issue Categorisation
Milestone
No milestone
2 participants
@brson @remram44
@brson
Copy link
Contributor

brson commented Mar 16, 2017

This will reduce binary size considerably.

cc #982

@brson brson added enhancement help wanted labels Mar 16, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Mar 17, 2017

This is a matter of changing .travil.yml and appveyor.yml.
@remram44

This comment has been minimized.

Sign in to view
Copy link

remram44 commented Mar 30, 2017

I'm running into something similar to rust-lang/cargo#2738:

   Compiling rustup-mock v1.0.0 (file:///buildslave/src/rustup-mock)
error: the linked panic runtime `panic_unwind` is not compiled with this crate's panic strategy `abort`

Some dependencies need panic=unwind...

@Diggsey Diggsey added this to Testing & infrastructure in Issue Categorisation May 3, 2017

@Diggsey Diggsey moved this from Testing to Build & Infrastructure in Issue Categorisation May 4, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented May 12, 2017

One consideration with panic=abort: if an installation transaction panics then that transaction will not rollback. I'm not sure how heavily to weigh that - leaving unwinding on would certainly make rustup more resilient to bugs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.