Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix `utils::copy_file` for symlink. #1521
Conversation
This comment has been minimized.
This comment has been minimized.
Ping. |
2 similar comments
This comment has been minimized.
This comment has been minimized.
Ping. |
This comment has been minimized.
This comment has been minimized.
Ping. |
This comment has been minimized.
This comment has been minimized.
@alexcrichton, anything I can do to move this along? |
This comment has been minimized.
This comment has been minimized.
@reitermarkus unfortunately rustup doesn't have a lot of active development and I don't personally have enough time to take a deep dive here to see if this is the correct fix or not (or what sort of unintended fallout this might have) |
This comment has been minimized.
This comment has been minimized.
@alexcrichton, no worries. For what it's worth, this patch has been integrated into the Homebrew package for a month now without any bug reports, if that is any indication on correctness. |
This comment has been minimized.
This comment has been minimized.
Given this fixes an issue that is affecting several people and seems to be working for Homebrew, I'm going to merge this. Thanks for the PR @reitermarkus ! |
reitermarkus commentedOct 4, 2018
•
edited
When
rustup-init
is a symlink, create a symlink to that symlink instead of resolving it first. This is also in line with using theno-self-update
feature, to allow managing therustup
version with Homebrew.Fixes #1512.