New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `utils::copy_file` for symlink. #1521

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
3 participants
@reitermarkus
Copy link
Contributor

reitermarkus commented Oct 4, 2018

When rustup-init is a symlink, create a symlink to that symlink instead of resolving it first. This is also in line with using the no-self-update feature, to allow managing the rustup version with Homebrew.

Fixes #1512.

@reitermarkus

This comment has been minimized.

Copy link
Contributor Author

reitermarkus commented Oct 12, 2018

Ping.

2 similar comments
@reitermarkus

This comment has been minimized.

Copy link
Contributor Author

reitermarkus commented Oct 26, 2018

Ping.

@reitermarkus

This comment has been minimized.

Copy link
Contributor Author

reitermarkus commented Nov 4, 2018

Ping.

@reitermarkus

This comment has been minimized.

Copy link
Contributor Author

reitermarkus commented Nov 12, 2018

@alexcrichton, anything I can do to move this along?

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Nov 13, 2018

@reitermarkus unfortunately rustup doesn't have a lot of active development and I don't personally have enough time to take a deep dive here to see if this is the correct fix or not (or what sort of unintended fallout this might have)

@reitermarkus

This comment has been minimized.

Copy link
Contributor Author

reitermarkus commented Nov 13, 2018

@alexcrichton, no worries. For what it's worth, this patch has been integrated into the Homebrew package for a month now without any bug reports, if that is any indication on correctness.

@nrc

This comment has been minimized.

Copy link
Member

nrc commented Jan 14, 2019

Given this fixes an issue that is affecting several people and seems to be working for Homebrew, I'm going to merge this. Thanks for the PR @reitermarkus !

@nrc nrc merged commit edf7206 into rust-lang:master Jan 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:fix-symlink branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment