Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link for component availability #1535

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
5 participants
@berkus
Copy link
Contributor

berkus commented Nov 5, 2018

This link is a community-supported history of component availability in nightly releases.
(Generated automatically from each nightly release)

I always forget the link, so probably having it up visible on rustup.rs is a good idea.

wdyt?

@berkus

This comment has been minimized.

Copy link
Contributor Author

berkus commented Dec 7, 2018

Anybody maintaining this repo at all?

@kinnison

This comment has been minimized.

Copy link
Collaborator

kinnison commented Jan 6, 2019

Hi @berkus

Everyone was super-busy over December but hopefully someone will be able to get to review this change soon.

I've seen that page before and it's super-useful, but I do worry about linking a community site from the official rustup pages. How about, instead, linking to https://rust-lang-nursery.github.io/rust-toolstate/ as that links through to the page you suggest adding, but it means there's only one place to update if the third party service changes location or is adopted?

@berkus

This comment has been minimized.

Copy link
Contributor Author

berkus commented Jan 7, 2019

I'm sure this can be adopted as an official page with some official rust url for sure. Right now it's just a community-maintained script and html pages, but I'm sure we can make it official?

rust-toolstate page is very limited in comparison, so i'd rather extend it with what @mexus did. I hope @mexus doesn't mind.

@h-michael

This comment has been minimized.

Copy link
Contributor

h-michael commented Jan 7, 2019

@berkus
FYI: There is a similar discuss.
rust-lang/rust#56951 (comment)

@kinnison

This comment has been minimized.

Copy link
Collaborator

kinnison commented Jan 7, 2019

@berkus I agree that the page by @mexus is of more use, but the rust-toolstate page is official AND already links to @mexus' work. My point being that I'd rather we linked to the official page and let it deal with when the better page's functionality is either subsumed or adopted.

@mexus

This comment has been minimized.

Copy link

mexus commented Jan 7, 2019

Hi everyone, first of all I'm super glad to see that people find my page (tool) that useful :) And yes, I'm willing to invest my time and effort in integrating the tool itself into the official toolset (provided the Rust team is ok with that), so I'll just go and ask on IRC how do I do that.

@berkus

This comment has been minimized.

Copy link
Contributor Author

berkus commented Jan 7, 2019

@kinnison that makes sense as a first step :)

@nrc

This comment has been minimized.

Copy link
Member

nrc commented Jan 14, 2019

@berkus do you want to change this PR to link to the toolstate page, or should we close it for now?

@berkus

This comment has been minimized.

Copy link
Contributor Author

berkus commented Jan 15, 2019

I will update it to link to toolslate, gimme a couple days or so.

Add link for component availability
I always forget the links, so having it up
visible on rustup.rs is probably a good idea.
@berkus

This comment has been minimized.

Copy link
Contributor Author

berkus commented Jan 15, 2019

@nrc here you go!

@nrc nrc merged commit 09ece90 into rust-lang:master Jan 16, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nrc

This comment has been minimized.

Copy link
Member

nrc commented Jan 16, 2019

Thanks!

@berkus berkus deleted the berkus:patch-1 branch Jan 17, 2019

@berkus

This comment has been minimized.

Copy link
Contributor Author

berkus commented Jan 17, 2019

When is it going to go live btw?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.