New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miri to rustup #1606

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@oli-obk
Copy link
Contributor

oli-obk commented Jan 9, 2019

It was just added to the distribution in rust-lang/rust#57086

This PR enables calling cargo miri after installing the miri component

@kinnison

This comment has been minimized.

Copy link
Contributor

kinnison commented Jan 9, 2019

Would it make sense to have a component_for_bin() to map cargo-miri to miri ?

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

oli-obk commented Jan 9, 2019

I was considering that, but I felt like miri is niche enough so it won't impact too many ppl. I can change it though if anyone thinks it's worthwile

@kinnison

This comment has been minimized.

Copy link
Contributor

kinnison commented Jan 9, 2019

component_for_bin() is pretty much only used to suggest component names to install if something is missing, but if someone tries to run cargo miri ... and then doesn't get the hint, they might be upset.

I don't mind either way, just thought i'd mention it in case you hadn't already considered and discarded the idea :-D

@kinnison

This comment has been minimized.

Copy link
Contributor

kinnison commented Jan 9, 2019

Change-wise this looks good 👍 but I would be more comfortable if it were rebased so that there aren't fixup commits in the sequence. I can do this if you don't have time, so long as someone can tell me how to update someone else's PR :-)

@oli-obk oli-obk force-pushed the oli-obk:patch-2 branch from 30aac99 to 98cbd2e Jan 9, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

oli-obk commented Jan 9, 2019

Updated

@kinnison
Copy link
Contributor

kinnison left a comment

LGTM. @nrc I think this is good for merge. I can't see any reason why it'd break anything.

@nrc nrc merged commit ab224e4 into rust-lang:master Jan 14, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nrc

This comment has been minimized.

Copy link
Member

nrc commented Jan 14, 2019

Thanks!

@superriva

This comment has been minimized.

Copy link

superriva commented Jan 15, 2019

Will miri component be availiable in the next rustup release (1.17.0)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment