Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Shell completions for Cargo #1646
Thanks for your contribution. Could you possibly tidy up the commit sequence (e.g. fold the fixes to formatting into the requisite commits instead of having a 'run rustfmt' commit) to make it easier to review?
I've put this PR on my list to watch but I'd like to see things a little tidier before I review.
I look forward to your changes.
Thanks for getting to looking over this. I've tidied up the rustfmt commit, but no other commits jumped out at me as being appropriate to tidy up. Is there anything else you would like cleaned up?
I should note that I wanted to keep @ricvelozo's commits mostly intact. They could get merged together with other commits, to condense everything, but I wanted to preserve his contribution.
kinnison left a comment
First up, thank you for submitting a PR and contributing to
This is not a bad PR, though there are a number of points which need cleanup. The big thing is that there's a distinct lack of tests.
Could we please have some basic tests for the new command you're adding?
@kinnison Sorry about the long time since the last update. As the famous quote goes, "Life... finds a way to always get in the way of projects."
I believe I have addressed all requested changes. Please let me know if there is anything else you would like modified.
No, that's very fair, I needed a kick up the backside it seems the past two weeks have been busy and somehow this slipped off my TODO without me noticing :(