Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up error messages #2035

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@ecumene
Copy link
Contributor

commented Oct 1, 2019

This diff is a bit hard to follow, but I changed the error messages from this:

$ rustup update stable
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-std' for 'armv7-apple-ios'
info: downloading component 'rust-std' for 'i686-apple-darwin'
error: component download failed for rust-std-i686-apple-darwin
info: caused by: could not download file from 'https://static.rust-lang.org/dist/2017-03-11/rust-std-1.16.0-i686-apple-darwin.tar.gz' to 'C:\Users\brian\.rustup\tmp\4y0bss25meytiiyq_file
info: caused by: error during download
info: caused by: [18] Transferred a partial file (transfer closed with 3544136 bytes remaining to read)

To this:

$ rustup update stable
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-std' for 'armv7-apple-ios'
info: downloading component 'rust-std' for 'i686-apple-darwin'
error: component download failed for rust-std-i686-apple-darwin
error: caused by: could not download file from 'https://static.rust-lang.org/dist/2017-03-11/rust-std-1.16.0-i686-apple-darwin.tar.gz' to 'C:\Users\brian\.rustup\tmp\4y0bss25meytiiyq_file
error: caused by: error during download
error: caused by: [18] Transferred a partial file (transfer closed with 3544136 bytes remaining to read)

As described in #991

@kinnison

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2019

I don't see the change in messages in your posting. Could you clarify what I'm supposed to be looking for?

Also, do not post formatting commits, instead reformat your existing commit please. I can show you how to rebase if you need help with that.

Rust fmt
@ecumene ecumene force-pushed the ecumene:fix-casual-errors branch from b46f735 to 7b53743 Oct 3, 2019
@ecumene

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Hi! Thanks for the feedback! This is the first time I contributed on a project this size. Commit is squashed!

As for where you can see the errors, just turn off wifi and run rustup default nightly

info: syncing channel updates for 'nightly-x86_64-apple-darwin'
error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-nightly.toml.sha256' to '/Users/mitchellhynes/.rustup/tmp/lupmzvmrx5e2nuha_file'
error: caused by: failed to make network request
error: caused by: https://static.rust-lang.org/dist/channel-rust-nightly.toml.sha256: error trying to connect: failed to lookup address information: nodename nor servname provided, or not known
error: caused by: failed to lookup address information: nodename nor servname provided, or not known
@kinnison

This comment has been minimized.

Copy link
Collaborator

commented Oct 4, 2019

I'm still failing to spot how the messages differ. What is your intent? (I could be being entirely blind here)

@ecumene

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

The level for logging error details was info, when it should be error, which makes it easier to spot where the error is coming from and what's associated with the source of the error

@kinnison

This comment has been minimized.

Copy link
Collaborator

commented Oct 6, 2019

Oh my goodness, so it is. I am so sorry, I was trying to work out how the colons were different the entire time 🤦‍♂

Copy link
Collaborator

left a comment

This looks good to me.

@kinnison kinnison merged commit 97bb7b9 into rust-lang:master Oct 6, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.