Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't make it an error for the self-update hash to be wrong #372
+23
−8
Conversation
This comment has been minimized.
This comment has been minimized.
|
r=me, but looks like tests are legit failing |
alexcrichton
closed this
Apr 29, 2016
alexcrichton
reopened this
Apr 29, 2016
brson
force-pushed the
brson:self-update-hack
branch
from
d011297
to
f110a8e
Apr 29, 2016
brson
merged commit 54a3ca7
into
rust-lang:master
May 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedApr 28, 2016
We've got problems with the updater and its hash being out
of sync. Thes patch considers a hash failure here a temporary
problem, prints a status message and exits with success.
cc #346
r? @alexcrichton