Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upVarious networking fixes #400
+1,004
−340
Conversation
brson
added some commits
May 5, 2016
This comment has been minimized.
This comment has been minimized.
|
It appears that rust-crypto has a native component that's failing the build. I'll find a sha256 implementation that doesn't. |
brson
force-pushed the
brson:hyperstuff
branch
from
7742513
to
5e3ee9a
May 6, 2016
alexcrichton
reviewed
May 6, 2016
src/rustup-utils/src/lib.rs
Outdated
| @@ -1,13 +1,15 @@ | |||
| #![feature(core_intrinsics)] // For type_name(). | |||
| #![feature(fundamental)] | |||
| #![feature(step_by)] | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
brson
May 6, 2016
Author
Contributor
Yeah, it just happened to be used by the sha code and didn't seem worth messing with, but it should be easy to remove. I'll look at it.
This comment has been minimized.
This comment has been minimized.
|
Nice! r+ from me basically, but looks like the openssl crate is still getting compiled on MinGW which is causing a build failure. Maybe something's bringing it in by accident? |
brson
added some commits
May 6, 2016
brson
merged commit 2b7c96f
into
rust-lang:master
May 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedMay 6, 2016
•
edited
Fixes #243, fixes #204, #344
r? @alexcrichton cc @sfackler @seanmonstar