Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImprovements to welcome screen #418
+304
−167
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This looks really cool. I love the way this emphasizes key info. Here are the things I noticed from just running it:
I'll give the code a review seperately. |
This comment has been minimized.
This comment has been minimized.
|
It looks like the markdown parsing is not applied to the post-install and pre-uninstall messages. |
This comment has been minimized.
This comment has been minimized.
|
Otherwise this lgtm. Very nice. |
This comment has been minimized.
This comment has been minimized.
|
r=me with the markdown processing applied to all the messages and with the bots passing. This will break tests in cli-install-interactive for sure. |
Diggsey
added some commits
May 8, 2016
This comment has been minimized.
This comment has been minimized.
|
That should be everything (just waiting on tests) |
Diggsey
merged commit 0de142a
into
master
May 8, 2016
Diggsey
deleted the
term-md
branch
May 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.

Diggsey commentedMay 8, 2016
term2markdownto parse markdown-style text and display formatted output in the terminalThe markdown crate exposes a
tokenizemethod which seems to be exactly fit for purpose. However, it exposes a private type in the return value which makes it unusable. I've opened an issue about it, but for the moment I've had to fork it and use a git dependency.r? @brson