Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMultiple CLI cleanups #419
Conversation
This comment has been minimized.
This comment has been minimized.
|
I didn't make it clear but the hidden synonyms aren't just compromise, but some are needed because I changed some of the 'preferred' verbs. |
This comment has been minimized.
This comment has been minimized.
|
I wonder if it'd be worth to also have a dedicated |
This comment has been minimized.
This comment has been minimized.
|
clap-rs/clap#469 may be applicable too. It's something I hadn't prioritized, but would be a very quick addition. |
This comment has been minimized.
This comment has been minimized.
|
|
brson
added some commits
May 7, 2016
brson
force-pushed the
brson:cli
branch
from
48966a1
to
4f91f61
May 9, 2016
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton I added |
brson
force-pushed the
brson:cli
branch
from
4f91f61
to
26fc2d7
May 9, 2016
This comment has been minimized.
This comment has been minimized.
|
Sounds good to me! Maybe some of the README could be updated as well? Other than r=me though, this all sounds good to me |
This comment has been minimized.
This comment has been minimized.
|
Well I made |
This comment has been minimized.
This comment has been minimized.
|
Ah ok, either way sounds good to me |
This comment has been minimized.
This comment has been minimized.
|
I went ahead and put the sweet commands in the README (but still not in |
brson commentedMay 8, 2016
•
edited
This adds help text for most subcommands and cleans them up in various ways.
The most important thing this does is try to resolve the bikesheddy problem of command synonyms that has been bugging me. That is, should the command be 'install' or 'update'? Should all install-like commands be the same verb or not?
From the commit, this is what I'm going for:
This reorganizes the verbs used in rustup commands. The concept here
is that every subcommand uses the most appropriate 'add/remove' verb
pair for itself, but implements hidden alternate commands using
the obvious other verbs.
So now the problematic verbs are:
toolchain install/toolchain uninstalltarget add/target removeoverride set/override unsetAdditional (hidden) synonyms are:
toolchain updatetoolchain add/toolchain removetarget add/target removeThis leaves the top level
rustup updateas the only non-hidden'update' command, which has the unique focus of updating everything.
@aturon Importantly, this means that in the README I'm showing
rustup toolchain install $toolchainfor the installation command, andrustup updatefor doing updates. I like emphasizing the 'toolchain' in early examples of install command because it's an important concept. This is slightly different than the blog post you have in your hands where I'm demonstrating the (shorter but non-existant)rustup installcommand, which I have not implemented here.