Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't panic when the NativeSslStream lock is poisoned #429
+34
−7
Conversation
This comment has been minimized.
This comment has been minimized.
|
I want to get this merged and publish a new release with the schannel fixes. Then I'm going to switch Windows back to OpenSSL. |
alexcrichton
merged commit 1ae8514
into
rust-lang:master
May 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedMay 10, 2016
This is just one small fix. More significant ones, including fixes for hanging downloads are in sfackler/schannel-rs#1, which will automatically show up in rustup builds.
This is probably not going to resolve all the problems seen in #423, but it will improve things.