Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMigrate to using libcurl for now instead of hyper #434
Conversation
This comment has been minimized.
This comment has been minimized.
|
I wouldn't merge this just yet as I'm still filling out some details on the Windows side of libcurl, but hopefully those should be addressed shortly. |
brson
reviewed
May 10, 2016
| @@ -152,161 +154,84 @@ pub fn tee_file<W: io::Write>(path: &Path, mut w: &mut W) -> io::Result<()> { | |||
| } | |||
| } | |||
|
|
|||
| pub fn download_file<P: AsRef<Path>>(url: hyper::Url, | |||
| pub fn download_file<P: AsRef<Path>>(url: &str, | |||
This comment has been minimized.
This comment has been minimized.
brson
May 10, 2016
Contributor
Can you instead switch to url::Url instead of str (it's already used instead of hyper::Url everywhere els)? I hope to push Urls upward through the APIs to improve type safety.
This comment has been minimized.
This comment has been minimized.
|
Thanks @alexcrichton |
alexcrichton
force-pushed the
alexcrichton:curl
branch
from
3eaf5ec
to
3c760af
May 10, 2016
This comment has been minimized.
This comment has been minimized.
|
Updated to thread |
alexcrichton
force-pushed the
alexcrichton:curl
branch
2 times, most recently
from
336d754
to
7e56481
May 10, 2016
This comment has been minimized.
This comment has been minimized.
|
I think this is good to go but I'd prefer to wait for Windows CI to come along and agree. That.. may take awhile. |
This comment has been minimized.
This comment has been minimized.
|
I killed the builds in front of it in appveyor. As soon as the first target is green I'll merge and start the build on master. |
This comment has been minimized.
This comment has been minimized.
|
This probably wants to wait at least until the MinGW target gets green, I still have yet to see a green build of curl on appveyor unfortunately. I think I've fixed it locally though. |
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton Failed on gnu. |
alexcrichton commentedMay 10, 2016
Unfortunately the move to rust-native-tls has had some hiccups on Windows and
Hyper also currently doesn't support features like HTTP proxies (but support's
coming soon!). For now this temporarily moves over to using libcurl to weed out
these problems until we get to a point where we're hyper's features are more
filled out. This also somewhat aligns with Cargo as well which is using libcurl
currently.
This does not use the
curlcrate on crates.io because it doesn't supportstreaming downloads. Instead I've got an in-progress rewrite which is just
binding much more directly to libcurl's APIs (e.g. exposing the callback
functions directly). This branch is in a git repo currently and I hope to
upstream it to curl-rust soon as well.