Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCompile on stable Rust #476
+454
−602
Conversation
alexcrichton
force-pushed the
alexcrichton:stable-rust
branch
from
2f7f43d
to
291000b
May 16, 2016
This comment has been minimized.
This comment has been minimized.
|
Nice! This isn't a criticism, but why did you choose to explicitly call |
This comment has been minimized.
This comment has been minimized.
|
Ah yeah that'd be possible, I just figured that the layer of a macro indirection probably wasn't worth it. |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
lgtm |
alexcrichton
force-pushed the
alexcrichton:stable-rust
branch
from
291000b
to
e995b45
May 17, 2016
alexcrichton
added some commits
May 17, 2016
alexcrichton
force-pushed the
alexcrichton:stable-rust
branch
2 times, most recently
from
0c1e32e
to
be106e7
May 27, 2016
alexcrichton
force-pushed the
alexcrichton:stable-rust
branch
from
be106e7
to
1d0a40d
May 27, 2016
alexcrichton
merged commit ba855de
into
rust-lang:master
May 27, 2016
alexcrichton
deleted the
alexcrichton:stable-rust
branch
May 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedMay 16, 2016
This removes the usage of #[fundamental] and intrinsics::type_name in the
notifications module. The
Notifyabletrait andNotifierstruct were alsoremoved in favor of just using
&Fn(Notification)where necessary. This changeis less ergonomic when crossing crate boundaries where
Notifiernaturallyimplemented
Notifyablefor multiple notification types before. Instead, nowclosures must be written as:
Which is to say that when crossing crate boundaries you need to remap
notification closures and leverage a
Fromimplementation.This crate does not currently compile on the stable channel due to the usage
of
panic::catch_unwindin the curl crate for now, but that will get fixed withthe next stable release, this is just paving the way forward!
Closes #58