Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd powerpc builds #534
Conversation
This comment has been minimized.
This comment has been minimized.
|
Ah looks like the build for OpenSSL needs to be updated to build powerpc as well, but otherwise I think this should be all that's needed. |
brson
force-pushed the
brson:powerpc
branch
from
726d779
to
d70a332
Jun 21, 2016
This comment has been minimized.
This comment has been minimized.
|
Updated the openssl builds. |
This comment has been minimized.
This comment has been minimized.
|
Looks like the OS may be |
brson
force-pushed the
brson:powerpc
branch
from
d70a332
to
b72d940
Jul 1, 2016
This comment has been minimized.
This comment has been minimized.
|
Updated again. |
alexcrichton
reviewed
Jul 1, 2016
ci/run-docker.sh
Outdated
| ;; | ||
| powerpc64-*-linux-*) | ||
| OPENSSL_OS=linux-ppc64 | ||
| OPENSSL_CC=powerpc64-linux-gnu-gcc |
This comment has been minimized.
This comment has been minimized.
alexcrichton
Jul 1, 2016
Member
Oh the failure now is:
powerpc64-linux-gnu-gcc: Command not found
I think that powerpc64 works by using the powerpc-linux-gnu compiler and then passing -m64 as a flag
brson
force-pushed the
brson:powerpc
branch
from
b72d940
to
435eba8
Jul 2, 2016
This comment has been minimized.
This comment has been minimized.
|
Updated again. |
This comment has been minimized.
This comment has been minimized.
|
Hey look it works! |
alexcrichton
merged commit 113965b
into
rust-lang:master
Jul 2, 2016
This comment has been minimized.
This comment has been minimized.
lu-zero
commented
Jul 2, 2016
|
Great ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedJun 15, 2016
Completely untested. How does this look @alexcrichton?
cc #531 @lu-zero