Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upWhen listing toolchains only list directories #544
+29
−2
Conversation
ipetkov
referenced this pull request
Jun 24, 2016
Closed
`rustup toolchain list` should only consider directories as toolchains #520
brson
merged commit 2ae4713
into
rust-lang:master
Jun 24, 2016
This comment has been minimized.
This comment has been minimized.
|
Beautiful! Thanks for writing a test! |
ipetkov
deleted the
ipetkov:fix-520
branch
Jun 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ipetkov commentedJun 23, 2016
valid toolchain names
file explorer, the OS may create some files there (e.g. .DS_Store on
OS X), which we do not want listed as installed toolchains