Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unavailable toolchains from `target list` #553
Conversation
Geemili
added some commits
Jun 29, 2016
brson
reviewed
Jul 1, 2016
| @@ -381,6 +382,7 @@ impl<'a> Toolchain<'a> { | |||
| component: component.clone(), | |||
| required: true, | |||
| installed: installed, | |||
| available: targ_pkg.available, | |||
This comment has been minimized.
This comment has been minimized.
brson
Jul 1, 2016
Contributor
This is almost there, but not quite. The TargettedPackage represented by targ_pkg is the "rust" package, but you need the TargettedPackage for each of the components of "rust" (the "rust" package is made up of other components like "rust-std", each with their own packages).
So in both these loops over components you're going to need to take the pkg and target fields of the component and then look up the targetted package in the manifest for that component. This is done the same way as the lookups for the previous rust_pkg and targ_pkg variables.
Thanks!
Geemili
added some commits
Jul 4, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks for the advice! I think I fixed it now, but I'm not sure. Also, as a side note, how do I run rustup instead of the installer? I haven't been able to find that information anywhere. |
brson
merged commit c0be63e
into
rust-lang:master
Jul 6, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks @Geemili! |
Geemili commentedJun 30, 2016
This should close issue #299