Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unavailable toolchains from `target list` #553

Merged
merged 4 commits into from Jul 6, 2016

Conversation

Projects
None yet
2 participants
@Geemili
Copy link
Contributor

Geemili commented Jun 30, 2016

This should close issue #299

Geemili added some commits Jun 29, 2016

Added code to remove unavailable toolchains from `target list`
I am not sure if it works because I can't get it to build on my Windows 10 machine
@@ -381,6 +382,7 @@ impl<'a> Toolchain<'a> {
component: component.clone(),
required: true,
installed: installed,
available: targ_pkg.available,

This comment has been minimized.

@brson

brson Jul 1, 2016

Contributor

This is almost there, but not quite. The TargettedPackage represented by targ_pkg is the "rust" package, but you need the TargettedPackage for each of the components of "rust" (the "rust" package is made up of other components like "rust-std", each with their own packages).

So in both these loops over components you're going to need to take the pkg and target fields of the component and then look up the targetted package in the manifest for that component. This is done the same way as the lookups for the previous rust_pkg and targ_pkg variables.

Thanks!

@Geemili

This comment has been minimized.

Copy link
Contributor Author

Geemili commented Jul 4, 2016

Thanks for the advice! I think I fixed it now, but I'm not sure.

Also, as a side note, how do I run rustup instead of the installer? I haven't been able to find that information anywhere.

@brson brson merged commit c0be63e into rust-lang:master Jul 6, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brson

This comment has been minimized.

Copy link
Contributor

brson commented Jul 6, 2016

Thanks @Geemili!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.