Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upHacky checksum fail #562
+121
−77
Conversation
AtheMathmo
added some commits
Jul 6, 2016
brson
reviewed
Jul 6, 2016
src/rustup-dist/src/dist.rs
Outdated
| } else { | ||
| match *manifest_dl_res.as_ref().unwrap_err().kind() { | ||
| // Checksum failed - issue warning to try again later | ||
| ErrorKind::ChecksumFailed{url: _, expected: _, calculated: _} => (download.notify_handler)(Notification::ManifestChecksumFailedHack), |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks good. Just that one nit to address in the verbose pattern. Thanks! |
This comment has been minimized.
This comment has been minimized.
|
Thanks, have made your suggested change. (I totally forgot I could pattern match like that :D ) |
brson
merged commit 571ec57
into
rust-lang:master
Jul 8, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
AtheMathmo
deleted the
AtheMathmo:hacky-checksum-fail
branch
Jul 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
AtheMathmo commentedJul 6, 2016
Resolved #524 (sort of...)
The implementation is also worryingly hacky.. Sorry. Please feel free to suggest a cleaner implementation if you see one.
Also it looks like I changed the formatting in places - if that is an issue let me know and I will correct it. Changes to
dist.rsbegin here