Skip to content

/rustup.rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to old download methods if server returns 403 #573

Merged
merged 1 commit into from Jul 12, 2016
+7 −5

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@brson @est31 @jethrogb @masklinn @alexcrichton
@brson
Copy link
Contributor

brson commented Jul 12, 2016

Fixes #452

Can't be tested because no network tests.

r? @alexcrichton
@est31

This comment has been minimized.

Sign in to view
Copy link

est31 commented Jul 12, 2016

Nice to see a fix being proposed so fast :)

@alexcrichton alexcrichton merged commit e6b867b into rust-lang:master Jul 12, 2016
0 of 2 checks passed

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jethrogb

This comment has been minimized.

Sign in to view
Copy link
Contributor

jethrogb commented Jul 12, 2016

Why don't you just test for all 400 codes?
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 13, 2016

@jethrogb That sounds good to me if you want to submit a patch.
@est31

This comment has been minimized.

Sign in to view
Copy link

est31 commented Jul 13, 2016

Can there be a new release?

@jethrogb jethrogb referenced this pull request Jul 13, 2016

Merged

Treat all HTTP client errors the same #578

@masklinn

This comment has been minimized.

Sign in to view
Copy link

masklinn commented Jul 13, 2016

@brson since server changes have already failed rustup.sh several time, wouldn't it be possible and simpler to generate the relevant manifests for older releases (at least the "release" channels anyway) and avoid the fallback?
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 14, 2016

@est31 I'm working on getting a new release out.

@masklinn That approach is possible, yes. It hasn't seemed worth it since this is also simple and the code already exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.