Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove toolchain directory if initial toolchain install fails #574
+27
−0
Conversation
brson
force-pushed the
brson:delete
branch
from
2e606b2
to
0ec646d
Jul 12, 2016
brson
force-pushed the
brson:delete
branch
from
0ec646d
to
9cc6517
Jul 12, 2016
alexcrichton
merged commit 011f79a
into
rust-lang:master
Jul 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedJul 12, 2016
If initial toolchain installation fails it leaves behind a directory,
which confuses rustup into thinking it's installed.
Again, I don't have any good way to test this. I think the best thing would be to write a FUSE filesystem, but I could also see using environment variables to mock out rustup's file system functions to return weird errors.
r? @alexcrichton
Related to #275 and #330