Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow any toolchain to be specified as the default during rustup installation. #586
+12
−1
Conversation
brson
reviewed
Jul 15, 2016
| }); | ||
| } | ||
|
|
||
| #[test] |
This comment has been minimized.
This comment has been minimized.
brson
reviewed
Jul 15, 2016
src/rustup-cli/setup_mode.rs
Outdated
| default_toolchain | ||
| } | ||
| None => "stable", | ||
| }; |
This comment has been minimized.
This comment has been minimized.
brson
Jul 15, 2016
Contributor
If you don't mind, let's take this warning out. I'm afraid it will look a bit too threatening. For now let's just not do any new error handling, even though if the toolchain fails to install the failure mode is pretty messy.
Instead, I'd prefer to make the way self_update responds to a failed toolchain install more robust, so that, if the toolchain install fails, the installer prints a message explaining what happened and how to proceed. But that's a pretty big patch on its own and I think can be done later.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks for this! |
jimmycuadra
force-pushed the
jimmycuadra:custom-default-toolchain
branch
from
23db1f6
to
f18aabc
Jul 15, 2016
brson
merged commit ac3a5fb
into
rust-lang:master
Jul 19, 2016
This comment has been minimized.
This comment has been minimized.
liuchong
commented
Sep 16, 2017
|
Got here from #559 |
jimmycuadra
deleted the
jimmycuadra:custom-default-toolchain
branch
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jimmycuadra commentedJul 15, 2016
Instead of restricting the
--default-toolchainargument torustup-initto one of the release channel names, allow any toolchain specification, but warn the user if they do so, since this makes it easier to accidentally install rustup with an invalid toolchain name.Fixes #559.