Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDetect ARMv7 CPUs without NEON extensions and treat as ARMv6 #593
Conversation
This comment has been minimized.
This comment has been minimized.
|
NB I don't have any other ARM machines on which I could test this. |
This comment has been minimized.
This comment has been minimized.
|
AppVeyor failure seems like an unrelated network error https://ci.appveyor.com/project/brson/rustup-rs/build/1.0.401/job/t8lswqjhwcxg3020 |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the investigation and the patch @sourcefrog! @alexcrichton and @japaric what do you think of this? Seems like something's wrong with our target defs. |
This comment has been minimized.
This comment has been minimized.
|
Hi brson, are you suggesting maybe you instead want to change the ARMv7 build to work without NEON? That would be another option. Or, you could have a separate build for ARMv7+NEON vs without. I don't know how much of a boost use of NEON gives to Rust performance, or how common CPUs with and without it are. |
This comment has been minimized.
This comment has been minimized.
|
This seems like a fine patch to merge for now at least (to fix the target detection). I feel like any decision we make on the ARM target we'll eventually get wrong (unless we ship everyone ARMv5 compatible code), so I'm not sure if it's a strong indicator to change the target just yet. |
brson
merged commit de0dbdb
into
rust-lang:master
Jul 19, 2016
This comment has been minimized.
This comment has been minimized.
|
@sourcefrog oh I wasn't suggesting anything in particular. Getting toolchains to support the wide variety of arm configs is difficult and I just wanted confirmation from folks who are more familiar. Thanks again. |
This comment has been minimized.
This comment has been minimized.
|
For the record: the topic of Scaleway, ARMv7 and NEON has come up before in the users forum. The TL;DR is:
|
sourcefrog commentedJul 18, 2016
Fixes /issues/587