Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse the env_proxy crate for proxy environment variable handling #598
Conversation
inejge
added some commits
Jul 19, 2016
This comment has been minimized.
This comment has been minimized.
|
Should've referenced #401, but I wasn't aware of it. env_proxy replicates curl's env var handling (as documented in the man page) faithfully. As for the README, would you prefer a short section by itself, say "Proxy support" (after "Environment variables"?), or a paragraph somewhere else? I can add the commit with the change to this PR. |
This comment has been minimized.
This comment has been minimized.
|
@inejge This looks awesome. For the README, how about another 'working with' section, 'Working with HTTP proxies', after 'working with custom toolchains'? Can you make it a followup? I want to merge this one right now! |
brson
merged commit 05525da
into
rust-lang:master
Jul 21, 2016
inejge
deleted the
inejge:env-proxy
branch
Jul 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
inejge commentedJul 19, 2016
The crate env_proxy encapsulates the rules for selecting the appropriate proxy server for a target URL according to the contents of the current environment, closely following the convention used by curl. This PR replaces the local (and incomplete) proxy determination function with the one provided by that crate.