Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTry detecting sudo when running rustup-init #617
Conversation
inejge
added some commits
Jul 26, 2016
This comment has been minimized.
This comment has been minimized.
|
The Windows build failure is spurious. Other failures are much more interesting.
Since the sudo check seems fundamentally incompatible with the way in which the test harness works, I've added an override which skips it when testing. It's a kludge; maybe a |
This comment has been minimized.
This comment has been minimized.
|
Looks great @inejge! I'd prefer this code be sunk into the |
brson
merged commit 699e141
into
rust-lang:master
Jul 29, 2016
inejge
deleted the
inejge:sudo-detect
branch
Jul 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
inejge commentedJul 26, 2016
Re #608. Not all sudo setups keep HOME, e.g., the ones in RH-derived distros don't. For those, a sudo'd installation will not end up in user's home directory, which may be unexpected, but not ugly like rust-lang/cargo#2892. On Debian/Ubuntu and OS X the detection works as expected.