Skip to content

/rustup.rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen the range of entries seen as toolchains #620

Merged
merged 2 commits into from Jul 28, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@inejge @Diggsey
@inejge
Copy link
Contributor

inejge commented Jul 28, 2016

If only directory entries are chosen with is_dir(), the list will miss the symlinks/junctions to custom toolchains.

Fixes #603
@inejge
Widen the range of entries seen as toolchains 
If only directory entries are chosen with is_dir(), the list will
miss the symlinks/junctions to custom toolchains.

Fixes #603
Loading status checks…
b2226e9
@Diggsey

This comment has been minimized.

Sign in to view
Copy link
Contributor

Diggsey commented Jul 28, 2016

Thanks! Could you add a regression test for #603 ?
@inejge

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

inejge commented Jul 28, 2016

I've added a "show" output match to the existing test for rustup toolchain link.

@Diggsey Diggsey merged commit a71190c into rust-lang:master Jul 28, 2016
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@inejge inejge deleted the inejge:show-custom branch Jul 29, 2016

@inejge inejge referenced this pull request Jul 29, 2016

Merged

Handle active custom toolchain in "show" #621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.