Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle active custom toolchain in "show" #621
Conversation
inejge
force-pushed the
inejge:active-custom
branch
from
91790d3
to
742e471
Jul 28, 2016
inejge
referenced this pull request
Jul 28, 2016
Closed
`rustup show` fails when active toolchain is custom? #599
This comment has been minimized.
This comment has been minimized.
|
Does this perhaps need its own test? |
This comment has been minimized.
This comment has been minimized.
|
@inejge Yes, please do add a test. There should be some existing |
inejge
added some commits
Jul 28, 2016
This comment has been minimized.
This comment has been minimized.
inejge
force-pushed the
inejge:active-custom
branch
from
742e471
to
9aacd71
Jul 29, 2016
brson
merged commit c2ebdf3
into
rust-lang:master
Jul 29, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks again @inejge ! Going to deploy this in just a few hours. |
inejge
deleted the
inejge:active-custom
branch
Jul 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
inejge commentedJul 28, 2016
•
edited
Re #599. This is more complicated than it seems, because
showtries to fetch all components of the active toolchain, and a custom toolchain a) doesn't have them, and b) doesn't even have an enforced name form. This set of patches enforces the custom- prefix for custom toolchains and adds the minimum necessary logic to handle them inshow. It also updates the README to note the new requirement.Edit: whoops, wrong approach. I think I'll force push the new commits, the original ones are pointless.