Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDeploy MSI build artifacts #661
Conversation
This comment has been minimized.
This comment has been minimized.
|
The windows failure looks legit. Not sure what's going on with the unix builds, but it looks similar to something I saw building an older cargo rev recently. It looks like the hash of the openssl tarball changed! I suspect the appveyor settings for 'artifacts' and 'deployment' aren't quite right but I'll have to experiment with it myself. Thanks @Boddlnagg. |
This comment has been minimized.
This comment has been minimized.
|
I'm not sure if this will actually work, since the artifacts |
This comment has been minimized.
This comment has been minimized.
|
The appveyor failure is unrelated to this pr. Looks like a race in a pre-existing test. Trying to figure it out now. |
This comment has been minimized.
This comment has been minimized.
|
I've also fixed the travis failures in a separate PR. |
Boddlnagg
force-pushed the
Boddlnagg:msi-deploy
branch
from
56c19bb
to
063ddde
Aug 26, 2016
This comment has been minimized.
This comment has been minimized.
|
I just rebased this and removed some unrelated changes that belong to another PR. I have more changes ready, but I think I'm going to wait until this is merged. |
This comment has been minimized.
This comment has been minimized.
|
Thanks @Boddlnagg. Fighting fires now but haven't forgotten. |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@brson We need to do something with this - can I do anything to help? |
This comment has been minimized.
This comment has been minimized.
|
@Diggsey Yeah we do. I'm afraid I haven't looked too closely at the solution here, so I'm not sure the state of it. If you wanted you could try to get it building again and seeing if you can get it to pass the CI. |
This comment has been minimized.
This comment has been minimized.
|
I can offer some help if needed, though my time is limited.
According to this earlier comment of mine, I also have some more changes that build upon this PR ... I am going to see what that was and can try to prepare a PR. |
This comment has been minimized.
This comment has been minimized.
|
@brson On another note, I think the important thing with respect to MSI build and Windows support is that someone needs to decide about what it should look like from a more general perspective. I have outlined some thoughts here. (In short: My idea and proposal is to have an MSI-based installer replace |
This comment has been minimized.
This comment has been minimized.
|
@Boddlnagg thanks for the updates. Sorry for avoiding this for so long. I left a comment on the msi issue in response. |
This comment has been minimized.
This comment has been minimized.
|
Closing in favor of #1211 which looks like it's got some more action |
Boddlnagg commentedAug 18, 2016
This enables deployment of
rustup.msiand the corresponding SHA of the embedded executable. I don't know exactly how the corresponding AppVeyor settings work, so whoever is responsible for the original setup should have a look at this, since I'm not able to test it locally.