Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upmaking rustup prepend cargo bin to path instead of append #707
Conversation
This comment has been minimized.
This comment has been minimized.
|
Looking at the CI build I would say it's not that simple So it seems like I need to make that use a I try building this locally but don't seem to get the same issue. |
This comment has been minimized.
This comment has been minimized.
|
Looks good. Thanks @rjgoldsborough ! |
brson
merged commit f5cd405
into
rust-lang:master
Sep 3, 2016
brson
referenced this pull request
Nov 14, 2016
Closed
Cargo uses "its rustc" rather than the one mandated by the `rustup toolchain` #809
Diggsey
referenced this pull request
May 4, 2017
Closed
Does not work with ~/.cargo/bin not being the most important path #475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ducks commentedSep 1, 2016
A first attempt at fixing #475
I'm not sure if the change is this simple because I'm honestly not sure how to test this one.
But I changed the Toolchain::set_ldpath to prepend instead of append.
If you could share some advice on how to test I'm more than willing to do so :)