Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse released version of rustls dependency #711
Conversation
meqif
referenced this pull request
Sep 6, 2016
Merged
Check for unexpected cargo/rustc before install #705
This comment has been minimized.
This comment has been minimized.
|
Should I check in the changes to Cargo.lock as well? |
This comment has been minimized.
This comment has been minimized.
|
Before checking in the lockfile changes, the Windows builds succeeded but the Travis builds failed with:
After adding them it seems like those build issues are solved (at the time of writing this comment, the tests are running and at least one succeeded in Travis before squashing). I squashed the individual commits. Please let me know if you'd like me to change anything. |
brson
merged commit 70c5733
into
rust-lang:master
Sep 6, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks @meqif! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
meqif commentedSep 6, 2016
Currently master fails to build with:
I tracked
ringdown as a dependency ofrustlsindownload. Updatingrustlsto the latest version (0.1.2) fixes the issue.I'm not sure how unstable
rustls's API is, so I took the safe bet of clamping down to the exact version instead of relaxing to 0.1. Feel free to tell me to change it, though!