Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMade outputting of ANSI terminal escapes codes defensive #725
Conversation
brson
merged commit 8d5c597
into
rust-lang:master
Sep 30, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
gifnksm
referenced this pull request
Oct 23, 2016
Closed
`rustup.sh` uses ANSI color codes without checking if stdout is wired to a terminal #721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
raphaelcohn commentedSep 13, 2016
I'd actually like to do a bit more of a thorough job on this script, for example, tidy up use of the default root, make need_cmd check for grep / head if required, etc depending on detected OS, add support for BusyBox wget as well as curl, etc.