Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksum failures #759

Merged
merged 2 commits into from Oct 21, 2016

Conversation

Projects
None yet
2 participants
@brson
Copy link
Contributor

brson commented Oct 14, 2016

Fix checksum failures with new self-update process

This changes the update process in the following ways: the current
version is read from the server at /rustup/stable-release.toml; if the
version is different from the running version then rustup downloads
the new release from the archives at /rustup/archive/$version/.

Fixes #524

This is intended to be a temporary solution until the full solution detailed here is implemented.

r? @alexcrichton

Don't issue warnings about manifest checksum mismatches
Temporary hack to avoid issues with consistent checksumming on the
CDN.

Issue #524
@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Oct 14, 2016

I was pretty sleepy when I implemented this. Please read it closely.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 14, 2016

Looks good to me! It's intentional right that the sha256 file isn't downloaded and checked though, right?

Other than that after the compile error is fixed r=me

Fix checksum failures with new self-update process
This changes the update process in the following ways: the current
version is read from the server at /rustup/stable-release.toml; if the
version is different from the running version then rustup downloads
the new release from the archives at /rustup/archive/$version/.

Fixes #524

@brson brson force-pushed the brson:chk branch from 4d53ac6 to 40c4333 Oct 21, 2016

@brson brson merged commit d32ae1a into rust-lang:master Oct 21, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.