Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTreat an empty `CARGO_HOME` the same as an unset `CARGO_HOME` #767
Conversation
Diggsey
assigned
brson
Oct 21, 2016
brson
merged commit e88d503
into
master
Oct 21, 2016
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
Diggsey
deleted the
db-empty-cargodir
branch
Nov 21, 2016
nrc
unassigned
brson
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Diggsey commentedOct 21, 2016
Previously this would result in
$CARGO_HOME == $HOME, which was bad when rustup tries to uninstall itself...