Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCompletions #773
Conversation
This comment has been minimized.
This comment has been minimized.
|
This is awesome |
kbknapp
added some commits
Oct 23, 2016
This comment has been minimized.
This comment has been minimized.
|
That's a simple change - just let me know if you need me to change it, or any other aspects and I'd be happy to do so |
This comment has been minimized.
This comment has been minimized.
kbknapp
force-pushed the
kbknapp:completions
branch
from
dffc2e5
to
79dcc1e
Oct 24, 2016
This comment has been minimized.
This comment has been minimized.
|
I've removed the |
brson
merged commit ec46f9f
into
rust-lang:master
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kbknapp commentedOct 24, 2016
•
edited
This commit adds a command line option to generate completion scripts, as well as updates
clapto 2.16.0 which adds ZSH completion support.Here's a gif of the new ZSH support and the new
rustup completionssubcommand backing it.Specifically this commit adds
Finally, this PR adds some additional help documentation on the
completionscommand, and changes theREADME.mdslightly to reflect the new additions.Some notes about the ZSH script generated by
clap, it supports, subcommands, flags, args, and options. The options also automatically list theirpossible_values, and will automatically not list any arguments theyconflictwith. This may not be too applicable torustupsince I don't think many of those options are used, but it's good to note for future reference.Also, positional arguments, such as
toolchainin a few of the subcommands is changed to uppercase ASCII byclapin order to differentiate.Edit: removed verbiage about
--completions