Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCorrectly "detect" host endianness on MIPS #802
Conversation
xen0n
force-pushed the
xen0n:mips-endianness
branch
from
054c254
to
21dab8f
Nov 6, 2016
brson
merged commit 4fcdfdc
into
rust-lang:master
Nov 12, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
xen0n
deleted the
xen0n:mips-endianness
branch
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
xen0n commentedNov 6, 2016
•
edited
Counter-intuitively, Linux on MIPS reports the same machine name in
uname(2)output, regardless of endianness. So the current check isbogus, and will fail on little-endian boxes. However, because the endianness
is not runtime reconfigurable, binaries are guaranteed to only work on
platforms with the same endianness. Hence, we can rely on compile-time
cfg()checks to provide the correct host triple, despite the kernelnot providing that information.