Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRename ~/.multirust to ~/.rustup #830
Conversation
This comment has been minimized.
This comment has been minimized.
|
rustup.sh is already modified to use |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
r+ from me Thanks for writing it as you did, this is some crazy logic to follow, but all makes sense to me! (and was easy to read) |
brson
force-pushed the
brson:rustup-dir
branch
from
679abdd
to
fd9df20
Nov 23, 2016
brson
force-pushed the
brson:rustup-dir
branch
from
fd9df20
to
7ff2ece
Nov 29, 2016
This comment has been minimized.
This comment has been minimized.
|
Rebased. |
brson
force-pushed the
brson:rustup-dir
branch
from
7ff2ece
to
a07ee8c
Dec 1, 2016
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 1, 2016
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 2, 2016
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit a07ee8c
into
rust-lang:master
Dec 2, 2016
xen0n
referenced this pull request
Dec 7, 2016
Closed
Re-running rustup-init deletes multirust directory instead of migrating it #848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedNov 22, 2016
This renames the ~/.multirust directory to ~/.rustup. The logic for the upgrade is in
do_rustup_home_upgrade, and is defensive against errors. It amounts to moving an unrecognized~/.rustupfolder to~/.rustup.sh, then moving a~/.multirustdir to~/.rustup.If the upgrade fails then rustup will silently continue using
~/.multirust, though this code path doesn't have tests, and is unlikely to happen...After the upgrade, or during initial install this also sets up
~/.multirustas a symlink to~/.rustupin case there are tools depending on it. This is intended to be temporary, to avoid breakage while getting it done quickly.This needs some more manual testing before deployment but is ready for review.
r? @alexcrichton