Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDefault to MSVC on Windows #842
Conversation
This comment has been minimized.
This comment has been minimized.
|
r+ but looks like there's windows failures |
mzji
referenced this pull request
Dec 8, 2016
Closed
Change the default toolchain in the "Working with Rust on Windows" section #804
brson
force-pushed the
brson:msvc
branch
from
4795228
to
44323ac
Dec 11, 2016
This comment has been minimized.
This comment has been minimized.
|
Fixed. |
This comment has been minimized.
This comment has been minimized.
|
@bors r=alexcrichton |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 11, 2016
This comment has been minimized.
This comment has been minimized.
|
|
brson
force-pushed the
brson:msvc
branch
from
44323ac
to
f384d7b
Dec 12, 2016
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 12, 2016
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors retry |
bors
added a commit
that referenced
this pull request
Dec 12, 2016
This comment has been minimized.
This comment has been minimized.
brson
merged commit 858dd08
into
rust-lang:master
Dec 12, 2016
bors
referenced this pull request
Dec 12, 2016
Merged
Check for unexpected cargo/rustc before install #705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedDec 2, 2016
Instead of picking MSVC/GNU based on detection, just default to MSVC.
During install, if MSVC is not detected provide guidance.
This is more predictable and easier to explain.
r? @alexcrichton