Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upStatically linked the MSVC CRT #843
Conversation
alexcrichton
reviewed
Dec 2, 2016
| matrix: | ||
| - TARGET: i686-pc-windows-msvc | ||
| BUILD_MSI: 1 | ||
| - TARGET: i686-pc-windows-gnu | ||
| MINGW_URL: https://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win32/Personal%20Builds/mingw-builds/4.9.2/threads-win32/dwarf/i686-4.9.2-release-win32-dwarf-rt_v4-rev4.7z/download | ||
| MINGW_URL: https://s3.amazonaws.com/rust-lang-ci |
This comment has been minimized.
This comment has been minimized.
alexcrichton
Dec 2, 2016
Author
Member
This was a bit of an unrelated cleanup, I switched to the url that we're using for Rust and a few other projects, and AWS is generally much more reliable than sourceforge
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
This has some conflicts with the openssl-sys dep used by rustup's download crate. |
This comment has been minimized.
This comment has been minimized.
|
I may spend some time cleaning up the download crate soon to unblock this. |
alexcrichton
force-pushed the
alexcrichton:libcmt
branch
from
bd4594c
to
43a4219
Dec 12, 2016
This comment has been minimized.
This comment has been minimized.
|
Ok, updated the PR |
alexcrichton
force-pushed the
alexcrichton:libcmt
branch
2 times, most recently
from
e32fd94
to
274c182
Dec 13, 2016
This comment has been minimized.
This comment has been minimized.
|
openssl-sys still not working right |
alexcrichton
force-pushed the
alexcrichton:libcmt
branch
from
274c182
to
39b93fd
Dec 15, 2016
alexcrichton
force-pushed the
alexcrichton:libcmt
branch
from
39b93fd
to
146f230
Dec 15, 2016
This comment has been minimized.
This comment has been minimized.
|
Pushed some updates, let's see how it goes |
brson
merged commit cfda772
into
rust-lang:master
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedDec 2, 2016
This PR updates a few dependencies for support with
-C target-feature=+crt-staticand then updates CI to produce those relevantbinaries on Windows. This should produce binaries that don't require the MSVC
redistributables and instead work standalone.