Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add listing of installed targets #1808
Thank you for the review. I believe I need to add tests to
Something similar to:
Do you think that I am heading to the right direction?
I think I managed to implement all the required tests. I am not sure about README updates. Could you point me the place to make documentation changes @kinnison ?
I've got a question about the number of commits: Should I leave as is or squash them into one?
The added tests look excellent, thank you very much!
I'm happy with the commits as they are, or you could squash the three test commits into one.
Either way, I'll look to merge this in soon, unless anyone else objects.