Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve human-readable units #2043

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@Rudi3
Copy link
Contributor

Rudi3 commented Oct 7, 2019

Attempt to fix #2041.

Differentiates between B|B/s and IO-ops|IOPS and formats them human-friendly.

@Rudi3 Rudi3 force-pushed the Rudi3:fix_size_units branch 7 times, most recently from 8406bed to 559895b Oct 7, 2019
@Rudi3 Rudi3 changed the title Fix/improve human-readable units [don't merge] Fix/improve human-readable units Oct 7, 2019
@Rudi3 Rudi3 changed the title [don't merge] Fix/improve human-readable units [do not merge] Fix/improve human-readable units Oct 8, 2019
@Rudi3 Rudi3 force-pushed the Rudi3:fix_size_units branch from 559895b to b7f9514 Oct 8, 2019
@Rudi3 Rudi3 changed the title [do not merge] Fix/improve human-readable units Fix/improve human-readable units Oct 8, 2019
@kinnison

This comment has been minimized.

Copy link
Collaborator

kinnison commented Oct 8, 2019

Since this touches code @rbtcollins wrote, I'd like their opinion on it.

@kinnison kinnison requested a review from rbtcollins Oct 8, 2019
@kinnison kinnison added this to the 1.21.0 milestone Nov 10, 2019
@kinnison kinnison merged commit 017d981 into rust-lang:master Nov 11, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Rudi3 Rudi3 deleted the Rudi3:fix_size_units branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.