Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinnison/retry downloads #2121

merged 5 commits into from Nov 11, 2019


Copy link

kinnison commented Nov 11, 2019

In an attempt to close #1722 as a way to fix #1667, fix #1243, and to fix #2071 more fully, add support for cleanly retrying downloads a fixed number of times.

Also this contains a small cleanup which means we finalise the download tracker properly on errors

kinnison added 5 commits Nov 11, 2019
Previously we would fail to finalise the download tracker on error.
This ensures that we allow the download tracker to finish *before*
we then propagate any errors.

Signed-off-by: Daniel Silverstone <>
Since we could get 416 if the partial file is corrupted for
whatever reason, treat it as a non-client error and therefore
we might retry it.

Signed-off-by: Daniel Silverstone <>
This is to be used when the downloader decides it has to retry
a download (for example, if it timed out, the socket died, etc)

Signed-off-by: Daniel Silverstone <>
In order that we can cope with 416 and other fixable errors
when downloading components, retry the download a few times.

Signed-off-by: Daniel Silverstone <>
Signed-off-by: Daniel Silverstone <>
@kinnison kinnison force-pushed the kinnison:kinnison/retry-downloads branch from fd6b89d to e1a5fca Nov 11, 2019
@kinnison kinnison added this to the 1.21.0 milestone Nov 11, 2019

This comment has been minimized.

Copy link
Collaborator Author

kinnison commented Nov 11, 2019

@payload Thanks for the review, is there anything else you wanted to query?

@kinnison kinnison merged commit 9a7177c into rust-lang:master Nov 11, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
continuous-integration/appveyor/pr AppVeyor build succeeded
@kinnison kinnison deleted the kinnison:kinnison/retry-downloads branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.