Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make clippy faster by using checking before that operation #2122

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@lzutao
Copy link
Contributor

lzutao commented Nov 11, 2019

It wins nearly one minute after this PR.

@kinnison

This comment has been minimized.

Copy link
Collaborator

kinnison commented Nov 11, 2019

Is the expectation that cargo check is faster than cargo clippy on the dependencies?

@lzutao

This comment has been minimized.

Copy link
Contributor Author

lzutao commented Nov 11, 2019

Yes, that is.

@kinnison

This comment has been minimized.

Copy link
Collaborator

kinnison commented Nov 11, 2019

Thanks.

@kinnison kinnison merged commit 3d22207 into rust-lang:master Nov 11, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@lzutao lzutao deleted the lzutao:fast-clippy branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.