Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show active-toolchain with rustc info #2710

Merged
merged 4 commits into from Apr 29, 2021

Conversation

hi-rustin
Copy link
Member

close #2685

@hi-rustin hi-rustin changed the title how active-toolchain with rustc info show active-toolchain with rustc info Apr 5, 2021
@hi-rustin hi-rustin force-pushed the rustin-patch-show branch 2 times, most recently from ee9645f to c400594 Compare April 5, 2021 09:52
@hi-rustin

This comment has been minimized.

@hi-rustin

This comment has been minimized.

@kinnison
Copy link
Contributor

Could you please add a comment here showing what a full output of rustup show displays (before/after your PR if it has changed) and what rustup show --verbose shows?

I'm not entirely sure it's worth adding --verbose rather than just always showing the information so I'd like to see.

@hi-rustin
Copy link
Member Author

Without my change:

stable-x86_64-apple-darwin (default)

with my change but without verbose:

➜  rustup git:(rustin-patch-show) ./home/bin/rustup  show active-toolchain                                     
stable-x86_64-apple-darwin (default)
➜  rustup git:(rustin-patch-show) 

with my change and verbose:

➜  rustup git:(rustin-patch-show) ./home/bin/rustup  show active-toolchain --verbose
stable-x86_64-apple-darwin (default) - rustc 1.51.0 (2fd73fabe 2021-03-23)
➜  rustup git:(rustin-patch-show) 

@hi-rustin
Copy link
Member Author

@kinnison ping~

@rbtcollins
Copy link
Contributor

rbtcollins commented Apr 21, 2021

I think showing it in the same format that rustup show does would be better: one per line. Concretely this is better for folk using sed to query etc.

Better format
@hi-rustin
Copy link
Member Author

I think showing it in the same format that rustup show does would be better: one per line. Concretely this is better for folk using sed to query etc.

Fixed.

@kinnison kinnison merged commit d6db55d into rust-lang:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustup show active-toolchain could be more detailed
3 participants