Add illumos/OpenIndiana platform check in rustup.js #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I shall merge this, though there remain potential problems with the OI release which need looking into. |
AJ-Ianozi
pushed a commit
to AJ-Ianozi/getada-download
that referenced
this pull request
Mar 9, 2024
Add illumos/OpenIndiana platform check in rustup.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OpenIndiana (illumos), rustup.rs currently shows that it doesn't recognize the platform:
This change clears the confusion and adds the missing platform check to rustup.js:
I'm tagging @jclulow to verify if the platform checks added are thorough enough but also to verify that the curl command itself works on OpenIndiana. On OpenIndiana 5.11, I get a wall of
local: not founderrors but piping it into bash does make it work. I can try to look into the script laterCheers!