Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the recv_tos socket option #299

Merged
merged 5 commits into from Apr 26, 2022
Merged

Conversation

JoNil
Copy link
Contributor

@JoNil JoNil commented Apr 22, 2022

No description provided.

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

The addition sounds good, but this needs tests and Windows support (see https://docs.microsoft.com/en-us/windows/win32/winsock/ipproto-ip-socket-options).

src/sys/unix.rs Show resolved Hide resolved
@JoNil
Copy link
Contributor Author

@JoNil JoNil commented Apr 25, 2022

I didn't find the IP_RECVTOS symbol in winapi-rs. Does anyone know if it is supported there and is just not exposed?

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw commented Apr 25, 2022

I didn't find the IP_RECVTOS symbol in winapi-rs. Does anyone know if it is supported there and is just not exposed?

I can't find it either. Perhaps we should move to windows_sys (it has it: https://docs.rs/windows-sys/latest/windows_sys/Win32/Networking/WinSock/constant.IP_RECVTOS.html), but that's a larger topic. For now you can remove Window support and we'll open issue to add it later.

@JoNil
Copy link
Contributor Author

@JoNil JoNil commented Apr 25, 2022

In the last commit i added windows the the cfg so that it is not included :)

@Thomasdezeeuw Thomasdezeeuw merged commit 040769b into rust-lang:master Apr 26, 2022
18 checks passed
@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw commented Apr 26, 2022

Thanks @JoNil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants