add logic tests for ternarylogic #1958
Merged
+50
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously the output would just always be all zeroes
folkertdev
force-pushed
the
ternary-logic-tests
branch
from
18ad820 to
3fface7
Compare
Contributor
|
I would LOVE if we can test all 256 of the choices, but ig that's a job for |
Contributor
Author
|
Ralf did have some further testing suggestions, I'll add those to a follow-up then. But yeah exhaustive is overkill here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the output would just always be all zeroes.
this came up in rust-lang/miri#4678
r? @sayantn