New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vmla_* / vmlal_* #955
base: master
Are you sure you want to change the base?
Add vmla_* / vmlal_* #955
Conversation
r? @Amanieu (rust_highfive has picked a reviewer for you, use r? to override) |
VMLA is not a fused multiply-add. It involves an intermediate rounding step just like if you use two separate operations. Only VFMA is a fused multiply-add. |
Ping. The |
#[target_feature(enable = "neon")] | ||
#[cfg_attr(test, assert_instr(fmla))] | ||
pub unsafe fn vmla_f64(a: float64x1_t, b: float64x1_t, c: float64x1_t) -> float64x1_t { | ||
simd_fma(b, c, a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the mul_add
method on f64
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for delay an thank you for review. I will update this PR.
unrelated CI is failure due to OOM... |
CI should be fixed now. However you still haven't fixed the definitions of the functions:
The Have a look at this: https://godbolt.org/z/34Wo5n |
|
Add Vector multiply accumulate intrinsic.