Skip to content

make triagebot cuter#1756

Closed
jyn514 wants to merge 1 commit into
rust-lang:masterfrom
jyn514:cute
Closed

make triagebot cuter#1756
jyn514 wants to merge 1 commit into
rust-lang:masterfrom
jyn514:cute

Conversation

@jyn514

@jyn514 jyn514 commented Dec 16, 2023

Copy link
Copy Markdown
Member

hi i am new rust user can one of you experienced rust people review my code please

Comment thread src/handlers/assign.rs Outdated
const RETURNING_USER_WELCOME_MESSAGE: &str = "r? @{assignee}

({bot} has picked a reviewer for you, use r? to override)";
({bot} has picked a reviewer for you, use r? to override) (˶˃ᆺ˂˶)";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether this is appropriate here. Having a reviewer is something very positive, and they don't feel that happy to me. Maybe replace it with something more happy? The other ones fit very well though

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok is this happy enough like this:

(*・ω・)ノ

@Noratrieb Noratrieb Dec 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks great ferriscat

@apiraino

apiraino commented Dec 16, 2023

Copy link
Copy Markdown
Contributor

tbh I find this addition not really necessary. Why?

  • Point 1: I (among others) try to recognize the work of contributors on both ends of a PR (author and reviewers) with an explicit "thank you" message, imo more direct and personal than a hardcoded emoji
  • Point 2: I don't even know what that means and like me maybe others don't

edit: but I appreciate your intent to make new contributors feel somewhat more at ease

@jyn514 jyn514 closed this Apr 8, 2024
@jyn514 jyn514 deleted the cute branch April 8, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants