Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github token check #924

Closed
wants to merge 2 commits into from
Closed

Add github token check #924

wants to merge 2 commits into from

Conversation

apiraino
Copy link
Contributor

I use a script to retrieve the token from a keychain, I have fumbled with the command and assigned a wrong value to the github API token. The GitHub queries then failed but the error returned by the cli tool was confusing, took me a bit to understand where the problem was.

This check ensures that the Github token retrieved is syntactically correct (a-z0-9).

cc: @spastorino

@spastorino
Copy link
Member

I'm not sure if I'd "validate" the token in that way but 👍, I meant, whatever :)

cc @Mark-Simulacrum

src/github.rs Outdated Show resolved Hide resolved
@apiraino
Copy link
Contributor Author

I'm not sure if I'd "validate" the token in that way but +1, I meant, whatever :)

right, only "syntactically correct".

What would you otherwise suggest to validate the token (without performing an actual API call)?

Anyway, it's just a papercut so it's ok to simply close it 👍 (I just thought to point it out)

Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
src/github.rs Show resolved Hide resolved
@apiraino apiraino closed this Oct 21, 2020
@apiraino apiraino deleted the add-github-token-check branch October 21, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants